Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scrolling lag on Dataset Schema Tables #13162

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AlexxRosaa
Copy link

Fix scroll lag on dataset schema tables

Navigating to a "Dataset" and viewing the table under the "Schema" tab will sometimes cause scroll wheel lag or auto movement when there are over a certain amount of schema fields that are being rendered.

Change

  • If the number of rows is under 40 the scroll wheel will remain, otherwise, there is a check added to see if there are over 40 rows to remove the scroll wheel entirely to prevent lag and render all fields at once

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Apr 9, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Apr 9, 2025
@rtekal
Copy link
Contributor

rtekal commented Apr 10, 2025

This PR helps with the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants