Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spring): upgrade to SpringBoot 3.4 #13186

Merged
merged 1 commit into from
Apr 12, 2025

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Apr 11, 2025

  • Deprecate No Code migration
  • Fix spark-smoke-test (incorrect image tag, image target was not slim, missing python-build)
  • Added support for target to docker plugin

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs devops PR or Issue related to DataHub backend & deployment labels Apr 11, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Apr 11, 2025
@david-leifker
Copy link
Collaborator Author

Finding that swagger UI has some issues, working on it.

@david-leifker
Copy link
Collaborator Author

Solve for the openapi swagger docs was that some swagger libraries needed a few minor version bumps.

@david-leifker david-leifker changed the title feat(spring): upgrade to Spring 3.4 feat(spring): upgrade to SpringBoot 3.4 Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ub/upgrade/common/steps/ClearGraphServiceStep.java 0.00% 1 Missing ⚠️
...b/upgrade/common/steps/ClearSearchServiceStep.java 0.00% 1 Missing ⚠️
...e/common/steps/ClearSystemMetadataServiceStep.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@esteban esteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

* Deprecate No Code migration
@david-leifker david-leifker merged commit 5ee0b66 into datahub-project:master Apr 12, 2025
65 of 66 checks passed
david-leifker added a commit to david-leifker/datahub that referenced this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants