-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: using bake to build all images in a single step #13191
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
run: | |
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
0f48312
to
db23603
Compare
Building via bake makes better use of remote container builder resources bake fixes
f3aeecb
to
dcb24a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2059:info:2:24: Don't use variables in the printf format string. Use printf '..%s..' "$foo" [shellcheck]
datahub/.github/workflows/docker-unified.yml
Line 1064 in dcb24a2
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2059:info:5:25: Don't use variables in the printf format string. Use printf '..%s..' "$foo" [shellcheck]
datahub/.github/workflows/docker-unified.yml
Line 1064 in dcb24a2
run: | |
5f681ab
to
2f8591d
Compare
2f8591d
to
d5cd5a9
Compare
- name: run quickstart | ||
env: | ||
DATAHUB_TELEMETRY_ENABLED: false | ||
DATAHUB_VERSION: ${{ needs.setup.outputs.unique_tag }} | ||
DATAHUB_VERSION: pr-build | ||
DATAHUB_ACTIONS_IMAGE: ${{ env.DATAHUB_INGESTION_BASE_IMAGE }} | ||
ACTIONS_VERSION: ${{ needs.datahub_ingestion_slim_build.outputs.tag || 'head-slim' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
property "datahub_ingestion_slim_build" is not defined in object type {base_build: {outputs: {build_id: string}; result: string}; setup: {outputs: {backend_change: string; backend_only: string; branch_name: string; datahub_executor_change: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; integrations_service_change: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; short_sha: string; slim_tag: string; smoke_test_change: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string}; result: string}; smoke_test_matrix: {outputs: {cypress_batch_count: string; matrix: string; python_batch_count: string}; result: string}} [expression]
Building via bake makes better use of remote container builder resources## Checklist