-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ingest/snowflake): improvements for view ingestion #13383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (58.13%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
self, *, schema_name: str, db_name: str | ||
) -> List[SnowflakeView]: | ||
cur = self.connection.query( | ||
SnowflakeQuery.get_views_for_schema(schema_name, db_name), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when calling the method, db name goes first
@staticmethod
def get_views_for_schema(db_name: str, schema_name: str) -> str:
SnowflakeQuery.get_views_for_schema(schema_name, db_name), | |
SnowflakeQuery.get_views_for_schema(db_name=db_name, schema_name=schema_name), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
name=row["VIEW_NAME"], | ||
created=row["CREATED"], | ||
comment=row["COMMENT"], | ||
view_definition=row["VIEW_DEFINITION"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: this needs to be populated via show views
in cases where the role is not the owner of the view
Superseded by PR #14444 |
Improves upon #13369