Skip to content

Conversation

hsheth2
Copy link
Contributor

@hsheth2 hsheth2 commented Apr 30, 2025

Improves upon #13369

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

❌ Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...hub/ingestion/source/snowflake/snowflake_schema.py 53.33% 14 Missing ⚠️
...ahub/ingestion/source/snowflake/snowflake_query.py 66.66% 2 Missing ⚠️
...ingestion/source/snowflake/snowflake_schema_gen.py 60.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (58.13%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 30, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Apr 30, 2025
@hsheth2 hsheth2 changed the title WIP add logging for views in db feat(ingest/snowflake): improvements for view ingestion May 1, 2025
@hsheth2 hsheth2 marked this pull request as draft May 1, 2025 02:27
self, *, schema_name: str, db_name: str
) -> List[SnowflakeView]:
cur = self.connection.query(
SnowflakeQuery.get_views_for_schema(schema_name, db_name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when calling the method, db name goes first

    @staticmethod
    def get_views_for_schema(db_name: str, schema_name: str) -> str:
Suggested change
SnowflakeQuery.get_views_for_schema(schema_name, db_name),
SnowflakeQuery.get_views_for_schema(db_name=db_name, schema_name=schema_name),

Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

name=row["VIEW_NAME"],
created=row["CREATED"],
comment=row["COMMENT"],
view_definition=row["VIEW_DEFINITION"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this needs to be populated via show views in cases where the role is not the owner of the view

@sgomezvillamor
Copy link
Contributor

Superseded by PR #14444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants