Skip to content

feat(ui) Add ability to edit global template on homepage #14078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2025

Conversation

chriscollins3456
Copy link
Collaborator

This PR adds the edit and "Done" buttons for allowing users to edit the global template on the homepage in the new home page experience.

Originally we thought we wanted to make this editing experience "staged" but after discussion it's much easier and probably more expected to always have edits happen in place for these sort of interactions. So now you just click the edit button to get into editing the global template and have a warning actions bar where you can stop editing global.

image image image

Copy link

alwaysmeticulous bot commented Jul 14, 2025

🔴 Meticulous spotted visual differences in 43 of 1506 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit efcbf68. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jul 14, 2025

Bundle Report

Changes will increase total bundle size by 3.85kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.17MB 3.85kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 3.85kB 18.53MB 0.02%

Files in assets/index-*.js:

  • ./src/app/homeV3/HomePageContent.tsx → Total Size: 997 bytes

  • ./src/alchemy-components/components/ActionsBar/ActionsBar.tsx → Total Size: 517 bytes

  • ./src/app/homeV3/EditDefaultTemplateButton.tsx → Total Size: 676 bytes

  • ./src/app/homeV3/EditDefaultTemplateBar.tsx → Total Size: 940 bytes

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jul 14, 2025
Base automatically changed from cc--ch-530-edit-template-in-ui to master July 16, 2025 13:24
@chriscollins3456 chriscollins3456 force-pushed the cc--ch-512-edit-global-template branch from 2f986d6 to dc987d0 Compare July 16, 2025 15:06
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 26.80412% with 71 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nents/components/ActionsBar/ActionsBar.stories.tsx 0.00% 46 Missing ⚠️
...react/src/app/homeV3/EditDefaultTemplateButton.tsx 38.88% 11 Missing ⚠️
...eb-react/src/app/homeV3/EditDefaultTemplateBar.tsx 50.00% 10 Missing ⚠️
...my-components/components/ActionsBar/ActionsBar.tsx 71.42% 2 Missing ⚠️
...tahub-web-react/src/app/homeV3/HomePageContent.tsx 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (26.80%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jul 16, 2025
Copy link
Collaborator

@purnimagarg1 purnimagarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:21: Use $(...) notation instead of legacy backticks ... [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:360: Double quote to prevent globbing and word splitting [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:2:22: Use $(...) notation instead of legacy backticks ... [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:155: Double quote to prevent globbing and word splitting [shellcheck]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:63: Double quote to prevent globbing and word splitting [shellcheck]

run: echo "NAME_TZ=$(echo ${{ matrix.timezone }} | tr '/' '-')" >> $GITHUB_ENV

@chriscollins3456 chriscollins3456 merged commit b550b8a into master Jul 17, 2025
41 of 43 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--ch-512-edit-global-template branch July 17, 2025 20:04
kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants