-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ui) Add ability to edit global template on homepage #14078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Meticulous spotted visual differences in 43 of 1506 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit efcbf68. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 3.85kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
2f986d6
to
dc987d0
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. ❌ Your patch status has failed because the patch coverage (26.80%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:1:21: Use $(...) notation instead of legacy backticks ...
[shellcheck]
datahub/.github/workflows/build-and-test.yml
Line 124 in f2fdba3
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:360: Double quote to prevent globbing and word splitting [shellcheck]
datahub/.github/workflows/build-and-test.yml
Line 124 in f2fdba3
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2006:style:2:22: Use $(...) notation instead of legacy backticks ...
[shellcheck]
datahub/.github/workflows/build-and-test.yml
Line 124 in f2fdba3
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:155: Double quote to prevent globbing and word splitting [shellcheck]
datahub/.github/workflows/build-and-test.yml
Line 124 in f2fdba3
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:63: Double quote to prevent globbing and word splitting [shellcheck]
datahub/.github/workflows/build-and-test.yml
Line 128 in f2fdba3
run: echo "NAME_TZ=$(echo ${{ matrix.timezone }} | tr '/' '-')" >> $GITHUB_ENV |
…ject#14078) Co-authored-by: david-leifker <[email protected]> Co-authored-by: Chakru <[email protected]>
This PR adds the edit and "Done" buttons for allowing users to edit the global template on the homepage in the new home page experience.
Originally we thought we wanted to make this editing experience "staged" but after discussion it's much easier and probably more expected to always have edits happen in place for these sort of interactions. So now you just click the edit button to get into editing the global template and have a warning actions bar where you can stop editing global.