feat(permissions) Add platform privilege for editing global home page #14081
Conversation
github-actions
bot
added
product
|
🔴 Meticulous spotted visual differences in 18 of 1331 screens tested: view and approve differences detected. Meticulous evaluated ~10 hours of user flows against your PR. Last updated for commit 9c16166. This comment will update as new commits are pushed. |
datahub-cyborg
bot
added
the
needs-review
Bundle ReportChanges will increase total bundle size by 2.27MB (11.52%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
chriscollins3456
force-pushed
the
cc--ch-510-template-module-permissions
branch
from
9c16166 to
7a1e560
Compare
| @@ -40,7 +42,10 @@ public CompletableFuture<DataHubPageModule> get(DataFetchingEnvironment environm | |||
| PageModuleScope scope = input.getScope(); | |||
| com.linkedin.datahub.graphql.generated.PageModuleParamsInput paramsInput = input.getParams(); | |||
|
|
|||
| // TODO: check permissions if the scope is GLOBAL | |||
| if (input.getScope().equals(PageModuleScope.GLOBAL) | |||
There was a problem hiding this comment.
What does global scope mean?
There was a problem hiding this comment.
global means it's available for all users to use on their templates. we will eventually have a more rich UI/library of modules to choose from, but for now global custom modules will be the ones that you can add to your personal widget today
| mockOpContext, PoliciesConfig.MANAGE_HOME_PAGE_TEMPLATES_PRIVILEGE)) | ||
| .thenReturn(false); |
There was a problem hiding this comment.
Why does this work when the user doesn't have permissions? And vice versa below
There was a problem hiding this comment.
this is because these tests are deleting PERSONAL modules, the check for those is to check if you personally created them - that's the case for the one below
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
This PR adds the platform privilege for whether or not you can manage the global home page. Specifically, this controls whether you can create/editdelete global templates or global modules. This will also be used in the UI later for controlling who can see the edit button for editing a global global templates for the rest of folk.