-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(customHomePage): bring changes for query builder from Saas #14420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(customHomePage): bring changes for query builder from Saas #14420
Conversation
✅ Meticulous spotted visual differences in 107 of 1816 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 225c285. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 779 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do a quick chat tomorrow about what changes we should or shouldn't be taking here and just make sure we're on the same page
datahub-web-react/src/app/sharedV2/queryBuilder/GroupHeader.tsx
Outdated
Show resolved
Hide resolved
bbe056f
to
e57f621
Compare
e57f621
to
6dfa822
Compare
6dfa822
to
66fcc0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes make sense just one question on the fixed width situation
export const ConditionElementWithFixedWidth = styled.div` | ||
width: 175px; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh my comment never got posted - i'm just a little confused why we added this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a problem when the latest select (the value select) is stretched because of long text inside and that's ok. But because of it the first two selects become stretched too. So I've added this width to avoid stretching of the first two selects.
Changes from Saas: