Skip to content

Conversation

v-tarasevich-blitz-brain
Copy link
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Aug 11, 2025

Changes from Saas:

  • updated types for LogicalPredicate/PropertyPredicate
  • added wrappers for PropertySelect/OperatorSelect to correctly show ValueSelect with long label

Copy link

alwaysmeticulous bot commented Aug 11, 2025

✅ Meticulous spotted visual differences in 107 of 1816 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 225c285. This comment will update as new commits are pushed.

Copy link

codecov bot commented Aug 11, 2025

Bundle Report

Changes will increase total bundle size by 779 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.51MB 779 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 779 bytes 18.86MB 0.0%

Files in assets/index-*.js:

  • ./src/app/sharedV2/queryBuilder/builder/types.ts → Total Size: 247 bytes

  • ./src/app/sharedV2/queryBuilder/valueInputs/EntitySearchValueInput.tsx → Total Size: 3.57kB

  • ./src/app/sharedV2/queryBuilder/builder/utils.ts → Total Size: 2.58kB

  • ./src/app/sharedV2/queryBuilder/styledComponents.ts → Total Size: 3.09kB

  • ./src/app/sharedV2/queryBuilder/Condition.tsx → Total Size: 2.05kB

  • ./src/app/sharedV2/queryBuilder/OperatorSelect.tsx → Total Size: 708 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/form/sections/relatedEntities/RelatedEntitiesSection.tsx → Total Size: 1.59kB

  • ./src/app/sharedV2/queryBuilder/PropertySelect.tsx → Total Size: 660 bytes

  • ./src/app/sharedV2/queryBuilder/QueryBuilder.tsx → Total Size: 3.04kB

  • ./src/app/homeV3/modules/assetCollection/DynamicSelectAssetsTab.tsx → Total Size: 357 bytes

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Aug 11, 2025
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do a quick chat tomorrow about what changes we should or shouldn't be taking here and just make sure we're on the same page

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Aug 11, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--custom-home-page--fixes-for-query-builder branch from bbe056f to e57f621 Compare August 12, 2025 07:10
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Aug 12, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--custom-home-page--fixes-for-query-builder branch from e57f621 to 6dfa822 Compare August 13, 2025 07:11
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense just one question on the fixed width situation

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Aug 20, 2025
Comment on lines +15 to +17
export const ConditionElementWithFixedWidth = styled.div`
width: 175px;
`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my comment never got posted - i'm just a little confused why we added this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a problem when the latest select (the value select) is stretched because of long text inside and that's ok. But because of it the first two selects become stretched too. So I've added this width to avoid stretching of the first two selects.

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Aug 27, 2025
@chriscollins3456 chriscollins3456 merged commit b1d96ab into master Aug 27, 2025
35 checks passed
@chriscollins3456 chriscollins3456 deleted the vt--custom-home-page--fixes-for-query-builder branch August 27, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants