feat(snowflake): add China region support #14434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lakecomputing.cn domain 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
the
ingestion
sgomezvillamor
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
treff7es
approved these changes
Aug 12, 2025
hsheth2
reviewed
Aug 12, 2025
| @@ -110,6 +109,10 @@ class SnowflakeConnectionConfig(ConfigModel): | |||
| default=None, | |||
| description="OAuth token from external identity provider. Not recommended for most use cases because it will not be able to refresh once expired.", | |||
| ) | |||
| snowflake_domain: str = pydantic.Field( | |||
| default=DEFAULT_SNOWFLAKE_DOMAIN, | |||
| description="Snowflake domain. Use 'snowflakecomputing.com' for most regions or 'snowflakecomputing.cn' for China (cn-northwest-1) region.", | |||
There was a problem hiding this comment.
would it be possible for us to automatically figure this out from the region / account ID?
There was a problem hiding this comment.
I considered that but there are some legacy account ids without the region info. While we could likely overcome that, I think that:
- as of today, default works for most 99.99999% of users
- explicit is better than implicit, this can be opinionated though
- future-proof if snowflake adds more regions with different domains
…ain support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
sgomezvillamor
deleted the
feature/ing-1016/feat-snowflake-support-china-region
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Snowflake China region (cn-northwest-1) which uses the
snowflakecomputing.cndomain instead of the standardsnowflakecomputing.com.Changes:
snowflake_domainconfiguration parameter (defaults tosnowflakecomputing.com, supportssnowflakecomputing.cnfor China)app.snowflake.cn(TBC if this is really needed!)Usage:
For China region customers:
🤖 Generated with Claude Code