Skip to content

fix(ingest): only add to samples where platform match #14722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 11, 2025
Merged

fix(ingest): only add to samples where platform match #14722

merged 10 commits into from
Sep 11, 2025

Conversation

anshbansal
Copy link
Collaborator

Some ingestions emit platforms that are not the same as ingestion. e.g. dbt might ingest snowflake lineage but we don't want to start showing snowflake in dbt ingestions.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 10, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tadata-ingestion/src/datahub/utilities/urns/urn.py 90.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Sep 10, 2025
sgomezvillamor
sgomezvillamor reviewed Sep 10, 2025
View reviewed changes
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Sep 10, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Sep 10, 2025
sgomezvillamor
sgomezvillamor reviewed Sep 10, 2025
View reviewed changes
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Sep 10, 2025
@github-actions github-actions bot requested a deployment to datahub-wheels (Preview) September 11, 2025 06:39 Abandoned
@anshbansal anshbansal merged commit 137ffb7 into master Sep 11, 2025
60 checks passed
@anshbansal anshbansal deleted the ab-2025-sep-10-only-add-cases-where-platform-id-same-as-urn-platform branch September 11, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @sgomezvillamor