fix(frontend): restrict TLS to 1.2+ in CustomHttpClientFactory#16215
Open
david-leifker wants to merge 1 commit intomasterfrom
Open
fix(frontend): restrict TLS to 1.2+ in CustomHttpClientFactory#16215david-leifker wants to merge 1 commit intomasterfrom
david-leifker wants to merge 1 commit intomasterfrom
Conversation
datahub-cyborg
bot
added
the
needs-review
- Use SSLContext.getInstance("TLSv1.2") to disable TLS 1.0/1.1
- Restrict Apache SSLConnectionSocketFactory to TLSv1.2 and TLSv1.3
- Update test to expect TLSv1.2 protocol
- Document breaking change in docs/how/updating-datahub.md
Addresses insecure TLS finding (Aikido).
Co-authored-by: Cursor <cursoragent@cursor.com>
david-leifker
force-pushed
the
custom-http-tls
branch
from
8d04d07 to
c2e2008
Compare
|
✅ Meticulous spotted 0 visual differences across 1002 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit c2e2008. This comment will update as new commits are pushed. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportBundle size has no change ✅ |
craig-rueda
approved these changes
Feb 14, 2026
craig-rueda
reviewed
Feb 14, 2026
| .setSSLSocketFactory( | ||
| new SSLConnectionSocketFactory( | ||
| getSslContext(path, pass, type), | ||
| new String[] {"TLSv1.2", "TLSv1.3"}, |
Contributor
There was a problem hiding this comment.
Should this be a config?
datahub-cyborg
bot
added
pending-submitter-response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.