-
Notifications
You must be signed in to change notification settings - Fork 316
Add DeepCalib, Moge-2 ops & Add Video Undistortion op #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Qirui-jiao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances video processing capabilities by introducing three new operators. These additions enable users to perform static camera calibration using both DeepCalib and the more accurate Moge-2 models, and to correct video distortions. The new functionalities streamline the preparation of video data for various computer vision tasks by providing tools for precise camera parameter estimation and image correction. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces three new mappers for video processing: VideoCameraCalibrationStaticDeepcalibMapper, VideoCameraCalibrationStaticMogeMapper, and VideoUndistortMapper. The changes also include the necessary model loading utilities and constant definitions.
My review focuses on correctness, maintainability, and consistency. I've found a critical issue in the device handling logic for the new DeepCalib model loader that could cause a crash. I've also identified a high-severity issue in VideoUndistortMapper regarding inconsistent data access patterns that would prevent it from working in a pipeline with the new calibration mappers. Other comments include suggestions to improve logging and remove magic numbers.
Overall, the new features are a great addition, but the identified issues should be addressed to ensure robustness and interoperability of the new components.
data_juicer/ops/mapper/video_camera_calibration_static_deepcalib_mapper.py
Show resolved
Hide resolved
|
Updates on Jan 12:
|
Add three ops, including:
video_camera_calibration_static_deepcalib_mapper: Compute the camera intrinsics and field of view (FOV) for a static camera using DeepCalib.video_camera_calibration_static_moge_mapper: Compute the camera intrinsics and field of view (FOV) for a static camera using Moge-2.video_undistort_mapper: Undistort raw videos with corresponding camera intrinsics and distortion coefficients.