-
Notifications
You must be signed in to change notification settings - Fork 316
fix: use consistent key naming in tracer output #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use consistent key naming in tracer output #873
Conversation
Summary of ChangesHello @JohnGiorgi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the consistency and predictability of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request standardizes a key name in the tracer's output for better consistency, which is a good improvement. However, there are two issues to address. First, and most critically, the unit tests that rely on this key have not been updated, which will cause them to fail. The tests in tests/core/test_tracer.py must be updated within this PR. Second, to improve maintainability, the string keys "original_text" and "processed_text" should be defined as constants to avoid magic strings in the code.
6b3e402 to
b6a2385
Compare
Changed 'original text' to 'original_text' in trace_mapper() to be consistent with 'processed_text'. This makes the trace output keys use a consistent snake_case naming convention. Updated tests to match the new key name.
b6a2385 to
4d2177a
Compare
HYLcool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! And sorry for late response.
Summary
The
trace_mapper()method inTraceroutputs a JSONL file with inconsistent key naming:original text(with a space)processed_text(with an underscore)This PR fixes the inconsistency by changing
original texttooriginal_text, making both keys use snake_case.