chore: add conda recipe #9
Conversation
goanpeca
left a comment
goanpeca
left a comment
There was a problem hiding this comment.
Thanks for the work on this PR @romulorosa
Left some minor comments 🚀
meta.yaml
Outdated
| - typing-extensions >=4 | ||
| - uvicorn >=0.24.0 | ||
| - tomli >=2.0.0 | ||
| - mcp[cli] >=1.2.1 |
There was a problem hiding this comment.
Hi @romulorosa thanks for the PR!
It would be great to sort deps alphabetically as it make the erecipe much easier to parse and update in the future, thanks!
There was a problem hiding this comment.
Sure thing.
I initially considered doing it dynamically (conda recipes support Jinja) based on pyproject.toml, but I noticed some syntax that cannot be directly translated into what conda expects (such as "tomli>=2.0.0; python_version < '3.11'",). That would help reduce maintenance costs.
| - pip | ||
| commands: | ||
| - python -c "import mcp_compose" | ||
| - mcp-compose --help |
There was a problem hiding this comment.
Would be nice to add
- pip checkhere
| license_file: LICENSE | ||
| summary: "Composition server for the Model Context Protocol (MCP)." | ||
| doc_url: https://github.com/datalayer/mcp-compose | ||
| dev_url: https://github.com/datalayer/mcp-compose |
There was a problem hiding this comment.
I would recommend adding this sections as
home: https://github.com/datalayer/mcp-compose
summary: 'Composition server for the Model Context Protocol (MCP).'
description: |
A powerful, production-ready framework for composing and orchestrating Model
Context Protocol (MCP) servers with advanced management capabilities, REST API,
and modern Web UI. # Remember to specify the license variants for BSD, Apache,
GPL, and LGPL.
license: MIT
license_family: MIT
license_file: LICENSE
doc_url: https://github.com/datalayer/mcp-compose
dev_url: https://github.com/datalayer/mcp-composeThere was a problem hiding this comment.
No problem. Although the README says the repository is under BSD instead (https://github.com/datalayer/mcp-compose#-license)
There was a problem hiding this comment.
Oh my bad, license, and license_family can be updated with the correct values!
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - datalayer |
There was a problem hiding this comment.
Could you please add here also
@echarles
@eleonorecharles
@goanpecaIt would make it easier to copy paste the recipe in conda-forge
There was a problem hiding this comment.
Will add all of them to the recipe. The @ is not supported tho
meta.yaml
Outdated
| noarch: python | ||
| number: 0 | ||
| script: | | ||
| python -m pip install --no-deps --no-build-isolation -vv . |
There was a problem hiding this comment.
Maybe change this to
script: "{{ PYTHON }} -m pip install . -vv" ?
There was a problem hiding this comment.
I like the idea of using {{ PYTHON }} and am fine with removing the arguments as you prefer, although I would encourage keeping them. Since the recipe lists all the dependencies (so no need to consider pyproject.toml). As per the --no-build-isolation, we already have a predefined "host" environment containing exactly the build tools you want, so there is no need for pip to create a "sandbox" build environment.
meta.yaml
Outdated
| @@ -0,0 +1,56 @@ | |||
| {% set name = "mcp_compose" %} | |||
There was a problem hiding this comment.
Should this be mcp-compose @echarles ?
There was a problem hiding this comment.
mcp-compose looks nicer indeed :)
There was a problem hiding this comment.
Will change it. I used mcp_compose because that is how it is in the pyproject.toml
Line 10 in 6026538
3 participants
No description provided.