Test-DBALsnChain - Fix missing log backup (#7515) #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
hey @AdamJKoehler thank you for the PR! I'll take a look soon. |
gci -recurse test*lsn* | Invoke-DbatoolsFormatter
AdamJKoehler
commented
Sep 20, 2024
There was a problem hiding this comment.
@potatoqualitee I see the command you used was different than what I did. That makes sense as to how to use it. Thanks!
|
Thank you very much for your PR and your patience, Adam! Your fix will be in the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1)Purpose
Fixing issue with Test-DBALsnChain that skips over a log backup that is written during a full backup that is being processed, but has not written a CheckpointLSN that can be used for the DatabaseBackupLSN record on the log backup.
Approach
Adding an additional check to see if the FirstLSN of the transaction log backup is greater than the CheckpointLSN of the full backup (instead of the log backup DatabaseBackupLSN being equal to the FULL backup's CheckpointLSN). This allows for the first log backup after the FULL backup to not be skipped for evaluation in the backup chain for restore purposes.
Manual Pester Results:
LSN data from backup files affected, and the error message received:
