Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLDEV-1194] Create _experimental folder and move untested dags to this #130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions datarobot_provider/_experimental/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2025 DataRobot, Inc. and its affiliates.
#
# All rights reserved.
#
# This is proprietary source code of DataRobot, Inc. and its affiliates.
#
# Released under the terms of DataRobot Tool and Utility Agreement.
import logging

logger = logging.getLogger(__package__)

experimental_warning = (
"You have imported from the _experimental directory.\n"
"This directory is used for unreleased datarobot features.\n"
"Unless you specifically know better,"
" you don't have the access to use this functionality in the app, so this code will not work."
)
Comment on lines +12 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't read quite right to me, because my assumption is that "access" isn't the issue -- that is, feature flags will not be the reason for things not working. Maybe:

Suggested change
experimental_warning = (
"You have imported from the _experimental directory.\n"
"This directory is used for unreleased datarobot features.\n"
"Unless you specifically know better,"
" you don't have the access to use this functionality in the app, so this code will not work."
)
experimental_warning = (
"You have imported from the _experimental directory.\n"
"This directory is used for unreleased datarobot features.\n"
"Code from this directory may be untested and may change without warning."
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could call in the Docs. reinforcements as well 😄

@nate-goudreault if you feel like chiming in here.

Copy link
Contributor

@nate-goudreault nate-goudreault Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
experimental_warning = (
"You have imported from the _experimental directory.\n"
"This directory is used for unreleased datarobot features.\n"
"Unless you specifically know better,"
" you don't have the access to use this functionality in the app, so this code will not work."
)
experimental_warning = (
"You have imported from the _experimental directory.\n"
"This directory is used for unreleased DataRobot features.\n"
"Code from this directory may be untested and may change without warning."
)


logger.warning(experimental_warning)
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ myst-parser==3.0.1
black==24.10.0
pyyaml>=6.0.2
types-PyYAML>=6.0.12
freezegun
freezegun>=1.5.1
Empty file.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_pipeline_dag import datarobot_pipeline
from datarobot_provider._experimental.example_dags.datarobot_pipeline_dag import datarobot_pipeline


def test_dag_loaded(dagbag):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_azure_storage_batch_scoring_dag import (
from datarobot_provider._experimental.example_dags.datarobot_azure_storage_batch_scoring_dag import (
datarobot_azure_storage_batch_scoring,
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_gcp_storage_batch_scoring_dag import (
from datarobot_provider._experimental.example_dags.datarobot_gcp_storage_batch_scoring_dag import (
datarobot_gcp_batch_scoring,
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_aws_s3_batch_scoring_dag import (
from datarobot_provider._experimental.example_dags.datarobot_aws_s3_batch_scoring_dag import (
datarobot_s3_batch_scoring,
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_score_dag import datarobot_score
from datarobot_provider._experimental.example_dags.datarobot_score_dag import datarobot_score


def test_dag_loaded(dagbag):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_create_project_from_ai_catalog_dag import (
from datarobot_provider._experimental.example_dags.datarobot_create_project_from_ai_catalog_dag import (
create_project_from_aicatalog,
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# Released under the terms of DataRobot Tool and Utility Agreement.
import pytest

from datarobot_provider.example_dags.deprecated.datarobot_create_project_from_dataset_version_dag import (
from datarobot_provider._experimental.example_dags.datarobot_create_project_from_dataset_version_dag import (
create_project_from_dataset_version,
)

Expand Down