Improve metadata: fix match_time description, add ATP source, remove readme property#6
Open
olayway wants to merge 1 commit into
Open
Improve metadata: fix match_time description, add ATP source, remove readme property#6olayway wants to merge 1 commit into
olayway wants to merge 1 commit into
Conversation
…readme property - Fix match_time field description in match_stats resources: it stores match duration (HH:MM:SS), not clock time of day - Add atpworldtour.com as a sources entry (scripts scrape data from there) - Remove readme property from datapackage.json; unique content (scripts note) merged into README.md - Update README Source section: replace stale fork URL with the primary data source (atpworldtour.com) and the upstream scraping scripts repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
match_timefield description inmatch_stats_1991-2016andmatch_stats_2017resources: the field stores match duration scraped from the ATP page (e.g.01:20:00= 1h 20min), not clock time of dayhttps://www.atpworldtour.com/as asourcesentry — the scripts scrape data directly from that site, but it was not listed as a sourcereadmeproperty fromdatapackage.json— unstructured documentation belongs inREADME.mdonly; the one piece of unique content (note that scripts may break if the site is redesigned) has been merged intoREADME.mdSourcesection: replace staleanuveyatsufork URL (repo transferred todatasetsorg) with the primary data source URL and the upstream scraping-scripts repo