Configurable baseDir and bastionBaseDir

[michaelsembwever]

Added to collector.conf

# Where will collection tarballs (and log file) be saved on the bastion
#bastionBaseDir="/tmp/datastax"

# Where will collector be copied to and the collection tarball be saved on each node
#baseDir="/tmp/datastax"

[BrandonBordeaux]

Looks good to me. However, I think Yasser Mohamed asked for this, so it'll be good to get his input whether it covers the use case he had in mind.

[yassermohamed81]

Looks good to me @michaelsembwever and just the comment for the make file for refactoring or optimization.

[michaelsembwever]

thanks @yassermohamed81 , will take a look soon (haven't forgotten). doing too much scripting in the Makefile can be awkward, but improving it's checks and messaging is definitely warranted 👍

[arodrime]

Ah! Happy to see this made it in! I had clusters with /tmp mounted as "no_exec". There is a long lasting debate about allowing or not execution of scripts through /tmp. Making baseDir configurable (and differentiating it from bastionBaseDir) was much needed and is appreciated ; I admit I did it locally without ever taking the time to do it "properly" to contribute it back. Will try to do better next time I have a chance to contribute.

Thanks @michaelsembwever for taking care of this repo (as well). 👍