Add back lenses-based connectors #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to remove 5 connectors because JitPack failed to provide old dependencies.
On requests to rebuild, jitpack "succeeds" for 3.0.1 (I tried on my fork) but still fails to provide the dependencies, no info to troubleshoot further.
Newer versions (that use sbt instead of gradle) just fail. They fail locally for my as well.
Upon investigation, I found that locally build for 3.0.1 fails because some of the artifact storages no longer available and some artifacts can't be easily obtained. This affected other OSS projects.
Some of the fixes in these projects were to exclude the dependencies but it's unclear what can fail as result.
I found repo clones that seemed to work, also added some transitive dependencies explicitly to fix the build.
The fix: https://github.com/dlg99/stream-reactor/tree/3.0.1-fix-build specifically dlg99/stream-reactor@faf4192
Jitpack built the release and this project build succeeded locally when I used that release.