Skip to content

Conversation

@honourfish
Copy link
Contributor

No description provided.

Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a call maybe, but I think curling proto-include.tar.gz from a configured release is the best way to get the google & grpc headers now. Even in docker builds

&& rm -rf protoc-${PROTOC_VERSION}-linux-${PROTOC_ARCH}.zip

# Download common google api proto files.
ENV GOOGLE_COMMON_PROTOS_VERSION=1.50.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are present in the proto-include.tar.gz included on every release. the runes to install both the google headers and the grpc onese are just

rm -rf proto-include
curl -fsSOL https://github.com/datatrails/go-datatrails-common-api/releases/download/{{.DATATRAILS_COMMON_API_VERSION}}/proto-include.tar.gz
tar -zxf proto-include.tar.gz
rm proto-include.tar.gz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The avid taskfiles/Taskfile_apis.yml bootstrap step is a good reference

Copy link
Contributor

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. May want to huddle re use of proto-include.tar.gz

## Run gRPC mock server

```
docker run -p 4770:4770 -p 4771:4771 -v ~/workspace/go-datatrails-common-api:/protobuf -v ~/workspace/go-datatrails-common-api:/proto gripmock --imports=/protobuf,/usr/local/api-common-protos-master,/usr/local/include,/go/pkg/mod/github.com/envoyproxy/[email protected],/go/pkg/mod/github.com/grpc-ecosystem/grpc-gateway/[email protected] /proto/datatrails-common-api/assets/v2/assets/service.proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you use the proto-includes.tar these include paths get a lot simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants