Skip to content

[QC] Fix for (EmptyCatchBlock) Avoid empty catch blocks #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davejohnston wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[QC] Fix for (EmptyCatchBlock) Avoid empty catch blocks #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/test/java/io/harness/cf/client/api/CfClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ void shouldAllowEvaluationsToContinueWhenAuthFails(boolean shouldWaitForInit)
try (MockWebServer mockSvr = new MockWebServer()) {
mockSvr.setDispatcher(webserverDispatcher);
mockSvr.start();

try (CfClient client =
new CfClient(
makeConnectorWithMinimalRetryBackOff(mockSvr.getHostName(), mockSvr.getPort()),
Expand All @@ -173,6 +172,13 @@ void shouldAllowEvaluationsToContinueWhenAuthFails(boolean shouldWaitForInit)
System.out.printf(
"Test that xVariation doesn't block and serves default when auth fails, iteration #%d%n",
i);
// Add logging for visibility in case of exception
try {
client.waitForInitialization();
} catch (FeatureFlagInitializeException ex) {
System.err.println("Feature flag initialization failed: " + ex.getMessage());
}
}

boolean b1 = client.boolVariation("test", null, true);
boolean b2 =
Expand Down