Change submission logic for regular form posts

[caesay]

If using onSubmit, it is only called when the form is valid. If using an action instead, the form can be submitted at any time regardless of the validity. This is not consistent.

[caesay]

An alternative suggestion would be that you could expose the field state or validity via the onSubmit or onBeforeSubmit callback so we can make a decision ourselves. As it stands currently, there's no way to stop a form submission based on its validity unless we connect to the store ourselves or save isValid in the state based on the data in onUpdate.

[davidkpiano]

I'll have to give this a tiny bit more thought. Are there use-cases where developers expect actions.submit(model) to force-submit the form, no matter what?

[caesay]

So it seems that currently onSubmit is always ignored if the form is invalid, and action is always executed no matter what.

Maybe it would be better to move some things around, here's some suggestions:

• onBeforeSubmit could pass fieldState along with the event to the caller, this would be a good place to make a decision on whether we want to submit or not (we could check the form state ourselves and preventDefault if we wish).
• before calling onSubmit we could check defaultPrevented, and if it's true it could bail out of onSubmit for consistency with the action prop.
• There could be a prop on the form preventInvalidSubmit which would default to true and would prevent both mechanisms by default.
• if preventInvalidSubmit is false, onSubmit would now get executed on an invalid form if not handled/cancelled in onBeforeSubmit

If you tell me what you think is best I would be happy to implement it.

[davidkpiano]

The first option seems like the simplest way to go - hopefully, we can avoid adding extra props. In the future, we can consider something like actions.forceSubmit(model).