fix: resolve shim imports from packages outside workspace #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
vite-plugin-node-polyfillsfailed to resolve shim imports (likevite-plugin-node-polyfills/shims/process) from packages outside the workspace during the build phase.Problem
When building a project that imports packages from outside the main workspace (e.g., from a sibling workspace or monorepo package), Rollup would fail with:
This issue was reported in the reproduction case: https://github.com/Jinjiang/reproductions/tree/vite-polyfill-20251125
Root Cause
The
@rollup/plugin-injectplugin only provides atransformhook but not aresolveIdhook. When external packages reference Node.js globals (likeprocess,Buffer, orglobal), the inject plugin transforms them into import statements:However, without a
resolveIdhook, Rollup cannot resolve these imports when they're in packages outside the main workspace, causing the build to fail.Solution
Added a custom Rollup plugin called
vite-plugin-node-polyfills:shims-resolverthat provides aresolveIdhook to resolve shim imports. The plugin:require.resolve()The fix applies to all three global shims:
buffer,global, andprocess.Testing
Changes
shimsResolverPluginto handle resolveId for shim imports during build