Skip to content

Conversation

@GuavaFortress
Copy link
Contributor

Adding those settings where the user needs to make a selection.

Adding those settings where the user needs to make a selection.
@davidrapan
Copy link
Owner

Hi @GuavaFortress,

  • Many of the platform: select should be platform: switch instead and therefore also w/o "Enable" suffix
  • Compare names of entities you're adding w/ other profiles so you're not introducing new "strings"
    For example use just "Grid" instead of "Grid Setting"

@GuavaFortress
Copy link
Contributor Author

Hi @davidrapan

I changed the enable/disable selections for switches. I also updated some of the string names. Please see if they are okay now.

It was tricky to find those string names in the other inverter definitions. I had to open each definition and manually search for possible matches. Mostly I couldn't find matches. Is there an easier way to check for existing strings that I don't know about?

Thank you for your work.

@davidrapan
Copy link
Owner

It was tricky to find those string names in the other inverter definitions. I had to open each definition and manually search for possible matches.

Yeah, I know it's not ideal.. but most of the time looking into deye_p3.yaml is enough. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants