Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CR as line-end char #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kriyative
Copy link

No description provided.

@davidsantiago
Copy link
Owner

What is this for? The end-of-line is already configurable with the :end-of-line argument in both reading and writing.

@kriyative
Copy link
Author

  1. CR is the line-end convention used by Excel on OSX for CSV exports, so it seems to be quite common in the wild
  2. end-of-line does allow passing in CR, but that requires the caller to know a-priori the convention used in the file being read
  3. Adding a layer around clojure-csv to pre-test the line-end seems excessive, especially when clojure-csv is doing that anyway

Perhaps, I've missed something about the intended use of end-of-line ... would be happy to understand.

Cheers.

@Boubalou
Copy link

That is exactly what I was about to code. Well, any chance it gets merged so we do not have to fork it ourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants