feat: add custody-separated Peer Cash extension - #1707
Open
ADWilkinson wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
ADWilkinson
force-pushed
the
feat/peer-cash-extension
branch
from
August 14, 2026 13:21
a5a664f to
1b5e570
Compare
Author
|
Quality review update:
The 11 focused tests, typecheck, package build, portability check, and repository pre-commit gates pass. Both commits are GitHub-verified. The PR is mergeable and awaiting maintainer review. |
Author
|
Still current on this branch. Happy to rebase if the extension layout moved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1708.
@lucid-agents/peer-cash, a native Lucid extension that contributesruntime.peerCash0.1.0Security boundary
This package does not accept private keys, sign transactions, or broadcast them. Mutating methods return JSON-safe unsigned Base transaction plans. The host wallet must inspect, sign, submit, and confirm each transaction in order. That keeps Lucid wallet connectors, account-abstraction policies, and external signers in control of custody.
Why this is Lucid-native
Lucid uses typed runtime slices. This implementation follows the current extension kernel, exposes one
peerCashruntime directly, and leaves entrypoint selection and wallet policy to the host application.Validation
bun test— 1,498 passed, 58 environment-gated skips, 0 failedbun run build:packagesbun run type-checkbun run test:docsbun test packages\/peer-cash\/src\/__tests__\/peer-cash.test.ts— 11 passedThe tests exercise the public Lucid builder/runtime interface and mock only the external Peer SDK boundary.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.