Skip to content

fix logs in recovery code path #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devhawk merged 1 commit into from
Dec 20, 2025
Merged

fix logs in recovery code path #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions transact/src/main/java/dev/dbos/transact/execution/DBOSExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,18 +301,15 @@ public Optional<Queue> getQueue(String queueName) {
String workflowId = Objects.requireNonNull(output.workflowId(), "workflowId must not be null");
String queue = output.queueName();

logger.debug("recoverWorkflow {}", workflowId);

if (queue != null) {
boolean cleared = systemDatabase.clearQueueAssignment(workflowId);
if (cleared) {
logger.debug(
"recoverWorkflow {} queue assignment {}",
workflowId,
cleared ? "cleared" : "not cleared");
logger.debug("recoverWorkflow clear queue assignment {}", workflowId);
return retrieveWorkflow(workflowId);
}
}

logger.debug("recoverWorkflow execute {}", workflowId);
return executeWorkflowById(workflowId, true, false);
}

Expand All @@ -336,8 +333,8 @@ public Optional<Queue> getQueue(String queueName) {
logger.info(
"Recovering {} workflows for executor {} app version {}",
pendingWorkflows.size(),
executorId(),
appVersion());
executorId,
appVersion);
for (var output : pendingWorkflows) {
try {
handles.add(recoverWorkflow(output));
Expand Down