Async take 2 #3
Merged
Async take 2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Jun 24, 2025
| () -> (Object) method.invoke(target, args) | ||
| ); | ||
|
|
||
| return null ; // always return null or default |
Member
There was a problem hiding this comment.
What happens if the return type is a primitive type? Will this throw an error?
Contributor
Author
There was a problem hiding this comment.
was going to add the code. need to return a default value
qianl15
reviewed
Jun 24, 2025
|
|
||
| /** | ||
| * | ||
| * To be removed: See AsyncInvocationHandler |
Member
There was a problem hiding this comment.
We might want to keep this for now. Separating sync from async.
qianl15
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For async invocation , client required to ignore the return value