MealPlanComponent list now leverages RxJS#1
Open
AlDrag wants to merge 1 commit intoddashwood:masterfrom
Open
Conversation
Created a new MealPlanListDatasource service. This is responsible for handling the data for the meal plan list. It leverages a BehaviorSubject for its data handling. It's still a bit imperative it in its design, but that does make it easy to follow. Going full declarative is possible by leveraging more complicated operators from RxJS, but it doesn't feel worth it. This could probably still be improved by storing the data as a map to allow more efficient updates, but this should be fine for now. NOTE: this is completely untested.
AlDrag
force-pushed
the
meal-plan-infinite-scrolling-with-rxjs
branch
from
4faae9a to
5d33a36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new MealPlanListDatasource service. This is responsible for handling the data for the meal plan list.
It leverages a BehaviorSubject for its data handling. It's still a bit imperative it in its design, but that does make it easy to follow. Going full declarative is possible by leveraging more complicated operators from RxJS, but it doesn't feel worth it.
This could probably still be improved by storing the data as a map to allow more efficient updates, but this should be fine for now.
NOTE: this is completely untested.
Feel free to ask any questions 😄