Fix dropped second-level strata headers in tbl_strata_nested_stack() (#2418)#2419
Merged
Conversation
…2418) The header-deduplication loop NA'd out repeated strata values in place while later iterations still grouped on those same columns. Once an outer level was NA'd, distinct groups across different outer-strata sections collapsed together, causing valid second-level headers to be dropped in all but the first group when using three or more strata levels. Compute the first-occurrence masks for each level against the original strata values before applying any NAs, so inner-level grouping is unaffected by NAs introduced for outer levels. Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixed bug in
tbl_strata_nested_stack()where second-level strata headers were dropped in all but the first group when using three or more strata levels. (#2418)If there is an GitHub issue associated with this pull request, please provide link.
closes #2418
Details
The header-deduplication loop NA'd out repeated strata values in place while later iterations still grouped on those same columns. Once an outer level was NA'd, distinct groups across different outer-strata sections collapsed together (e.g. all
(NA, "C")rows from different first-level sections merged into one group), so the "first row" logic dropped valid second-level headers in every first-level group except the first.The fix computes the first-occurrence masks for each level against the original strata values before applying any NAs, so inner-level grouping is no longer corrupted by NAs introduced for outer levels.
Verification
tests/testthat/test-tbl_strata_nested_stack.Rcovering the 3-level strata case from the issue. The test fails on the previous code and passes with the fix.test-tbl_strata_nested_stack.Rcontinue to pass.Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()usethis::use_spell_check()runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")usethis::use_spell_check()again