Add fallback support to tcptraceroute #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If traceroute does not support the -M (method), then fall back to tcptraceroute
|
Looks good, what platform did you test it on ? |
|
Hi, I am testing on Debian 10 host OS, and alpine linux docker image. I still have one scenario where tcptraceroute doesn't work, but traceroute -M tcp works... I don't understand yet :) Cheers, Damien |
|
Okay, ping me when your PR is ready so I can test it broadly on BSD and other unixes. |
|
Hi, It looks like my other use case is in relation to empty "TCP Options" being dropped by firewalls. The fix for tcptraceroute has been added in mct/tcptraceroute#14 Cheers, Damien |
|
Are we still needing this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If traceroute does not support the -M (method), then fall back to tcptraceroute