-
Notifications
You must be signed in to change notification settings - Fork 0
feat: agent eval mode for loop exit conditions #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6539f69
Loop loop-06fd8b6e-0085-4e90-9085-8f42c3f28568 iteration 1 — pass
114d5cb
style: fix biome formatting and import organization
0db07d2
fix: address self-review issues
8013db9
fix: address shepherd review gaps
8a94678
refactor: simplify agent evaluator and cleanup
f42d7bd
refactor(loop-handler): extract cleanupIterationTracking helper and s…
942c2c7
fix(schedule-manager): allow agent-mode scheduled loops with empty ex…
e022f5b
fix(loops): cancel orphaned eval task when parent loop is cancelled
7065025
docs: document agent eval mode and fix EvalMode type consistency
b7937af
refactor(loops): complete EvalMode enum rollout and add exhaustive sw…
3215a56
style(mcp-adapter): restore default EvalMode.SHELL on Zod schemas
e691389
fix(loop-manager): add runtime guard for invalid evalMode values
1f259cb
style: fix biome formatting after parallel resolver changes
707273f
refactor(loop): extract IterationResultFields type and reduce test bo…
c1269d5
refactor: simplify cleanup and remove redundant schedule update
4ed1e8e
fix: resolve pre-existing review issues #3, #4, #5
89f913f
fix: resolve Greptile PR review findings (P1 CLI bug, P2 eval prompt)
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documented example:
--maximizeis explicitly rejected inparseAgentModeArgswith the error "--minimize/--maximize are not valid with --eval-mode agent", so this command errors before ever reaching the service. This should be corrected once the CLI bug above is fixed.