fix: remove erroneous -- from podman exec command#61
Merged
Conversation
The two-phase shell flow (create + sleep + exec) inserted a bare `--` between the container ID and command in `podman exec`, causing crun to look for an executable named `--`. Remove it from both NativePodmanRuntime and OrbStackRuntime. Also add `strip_separator()` to defensively clear clap's `last = true` artifact when `mino run --` is invoked without a trailing command. Add tmux with TPM, resurrect, and continuum plugins to the base image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec_in_containerin bothNativePodmanRuntimeandOrbStackRuntimeinserted a bare--between the container ID and command inpodman exec. Since podman treats everything after the container ID as the command,--was interpreted as the literal executable — causingcrun: executable file '--' not found in $PATHon every baremino run.strip_separator()to handle clap'slast = trueleaking--into the command vec whenmino run --is invoked without a trailing command.Test plan
cargo test— 876 tests pass (840 unit + 23 binary + 13 integration)cargo clippy— cleanmino-dev rundrops into shell (verified)mino-dev run -- echo helloruns echo