Add linter offenses fixes to action backporter #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
approved these changes
Sep 27, 2024
Member
alecslupu
left a comment
alecslupu
left a comment
There was a problem hiding this comment.
👍
Looks ok, i have tested the code.
Member
|
@andreslucena you have failing specs |
Member
Author
|
I realized that I need to actually do the backports in the decidim-backporter script, as that's the one that actually generates the cherry-pick/PR. I'll do it when I have some availability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are some differences between the rubocop configuration between versions, there are some linter offences that happens in some versions and not in others.
See decidim/decidim#13444
This PR adds the automation for adding these linter fixes automated in the workflow