feat(vmrestore): add force option
#1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
feat/vmrestore/add-force-option
branch
14 times, most recently
from
e0efd0a to
b834223
Compare
hardcoretime
force-pushed
the
feat/vmrestore/add-force-option
branch
14 times, most recently
from
2a4e4b4 to
adf63b5
Compare
danilrwx
previously approved these changes
Jul 21, 2025
hardcoretime
force-pushed
the
feat/vmrestore/add-force-option
branch
from
e8cbac8 to
ebd1de8
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
danilrwx
previously approved these changes
Jul 22, 2025
added 8 commits
July 22, 2025 11:00
Signed-off-by: Roman Sysoev <[email protected]>
- fix typo - replace slog with deckhouse/pkg/log - remove vmop complited status(an uuid is used) - check that vm is existed when `forced` - check that vm is not pending when `forced` Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
feat/vmrestore/add-force-option
branch
from
97b134f to
74ed18c
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
z9r5
approved these changes
Jul 22, 2025
danilrwx
approved these changes
Jul 22, 2025
This was referenced Jul 22, 2025
Merged
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
restoreModeoption has been added to theVirtualMachineRestoreresource. It can take two values:safeandforced. Thesafemode is used when there are no conflicts with existing resources. Theforcedmode can be applied to a runningVirtualMachine, but it can be a destructive action if problems occur during the restoration process.Why do we need it, and what problem does it solve?
It is important to have the ability to restore a
VirtualMachineas soon as required.What is the expected result?
A
VirtualMachinecan be restored if there are no conflicts withVirtualDisksandVMIPresources. IfVirtualDisksare used by anotherVirtualMachineor aVMIPexists with an IP address reserved by anotherVirtualMachine, the restoration process will fail.Checklist
Changelog entries