Skip to content

chore(test): replace storage class creating with checking #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hardcoretime merged 2 commits into from
Jul 15, 2025
Merged

chore(test): replace storage class creating with checking #1255

hardcoretime merged 2 commits into from
Jul 15, 2025

Conversation

@hardcoretime
Copy link
Contributor

@hardcoretime hardcoretime commented Jul 15, 2025 •
edited
Loading

Description

Why do we need it, and what problem does it solve?

The tests should not depend on storage.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: api
type: chore
summary: "The E2E tests do not depend on storage."
impact_level: low

@hardcoretime hardcoretime force-pushed the chore/test/replace-sc-creating-with-checking branch from 617d6a4 to 639ea2e Compare July 15, 2025 08:50
@hardcoretime hardcoretime added this to the v0.23.0 milestone Jul 15, 2025
@hardcoretime hardcoretime force-pushed the chore/test/replace-sc-creating-with-checking branch 2 times, most recently from 0bd9ac3 to 0759a23 Compare July 15, 2025 10:37
@hardcoretime hardcoretime marked this pull request as ready for review July 15, 2025 10:45
@hardcoretime hardcoretime requested a review from danilrwx as a code owner July 15, 2025 10:45
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 15, 2025

Workflow has started.
Follow the progress here: Workflow Run

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@hardcoretime hardcoretime added the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jul 15, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jul 15, 2025
yaroslavborbat
yaroslavborbat requested changes Jul 15, 2025
View reviewed changes
@hardcoretime hardcoretime force-pushed the chore/test/replace-sc-creating-with-checking branch from 0759a23 to 988023a Compare July 15, 2025 17:21
@hardcoretime hardcoretime merged commit 1b07169 into main Jul 15, 2025
23 of 24 checks passed
@hardcoretime hardcoretime deleted the chore/test/replace-sc-creating-with-checking branch July 15, 2025 17:40
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@hardcoretime
chore(test): replace storage class creating with checking (#1255)
15e0eee 
Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

@danilrwx danilrwx Awaiting requested review from danilrwx danilrwx is a code owner

Assignees

@hardcoretime hardcoretime

Labels

None yet

Projects

None yet

Milestone

v0.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hardcoretime @deckhouse-BOaTswain @yaroslavborbat