fix(vmbda): resolve terminating status issue

[hardcoretime]

Description

• Use Hotpluggable field for validation
• Remove deprecated API

Why do we need it, and what problem does it solve?

When a VMBDA with a VirtualImage BlockDeviceRef is deleted, it remains in the Terminating phase because this block device cannot pass the Hotpluggable check.

What is the expected result?

When a VMBDA deletion request is performed, the VMBDA should be deleted.

Checklist

• The code is covered by unit tests.
• e2e tests passed.
• Documentation updated according to the changes.
• Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmbda
type: fix
summary: "The VMBDA with a VirtualImage BlockDeviceRef will now be deleted successfully when requested."

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactor hotplug detection to leverage the new Hotpluggable field and remove deprecated inference APIs, propagate the flag through the KVVM builder, and update tests and dependencies to resolve VMBDA terminating state.

Class diagram for updated BlockDeviceHandler hotplug logic

classDiagram
class BlockDeviceHandler {
  +getBlockDeviceStatusRefs(ctx, s)
  +getBlockDeviceTarget(volume, kvvmiVolumeStatusByName)
  +isHotplugged(volume, kvvmiVolumeStatusByName) bool
  +getBlockDeviceAttachmentName(ctx, kind, bdName, s)
}

class Volume {
  +Name
  +PersistentVolumeClaim
  +ContainerDisk
}

class PersistentVolumeClaim {
  +Hotpluggable: bool
}

class ContainerDiskSource {
  +Image
  +Hotpluggable: bool
}

BlockDeviceHandler --> Volume
Volume --> PersistentVolumeClaim
Volume --> ContainerDiskSource

Loading

Class diagram for KVVM builder changes with Hotpluggable propagation

classDiagram
class KVVM {
  +SetDisk(name, opts)
}

class SetDiskOptions {
  +ContainerDisk: string
  +IsHotplugged: bool
}

class ContainerDiskSource {
  +Image: string
  +Hotpluggable: bool
}

KVVM --> SetDiskOptions
SetDiskOptions --> ContainerDiskSource

Loading

File-Level Changes

Change	Details	Files
Refactor hotplug validation to use the Hotpluggable field	Simplified isHotplugged signature to return a bool and dropped error handling Updated getBlockDeviceStatusRefs to assign ref.Hotplugged directly Replaced legacy checks in ApplyVirtualMachineSpec with volume.ContainerDisk.Hotpluggable	images/virtualization-artifact/pkg/controller/vm/internal/block_device_status.go images/virtualization-artifact/pkg/controller/kvbuilder/kvvm_utils.go
Remove legacy hotplug inference APIs	Deleted canBeHotPlugged and its invocations Removed standalone isHotplugged helper in kvbuilder Removed the obsolete kvapi.go file	images/virtualization-artifact/pkg/controller/vm/internal/block_device_status.go images/virtualization-artifact/pkg/controller/kvbuilder/kvvm_utils.go images/virtualization-artifact/pkg/controller/kvapi/kvapi.go
Propagate Hotpluggable flag in KVVM disk builder	Added Hotpluggable field to ContainerDisk spec in SetDisk Adjusted struct initialization to pass opts.IsHotplugged	images/virtualization-artifact/pkg/controller/kvbuilder/kvvm.go
Update tests and module dependencies	Re-enabled vmbda-vi.yaml entry in e2e test kustomization Bumped kubevirt.io/api replace directive in go.mod	tests/e2e/testdata/vm-restore-force/vm/base/kustomization.yaml images/virtualization-artifact/go.mod

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

[deckhouse-BOaTswain]

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}