Skip to content

Conversation

eofff
Copy link
Contributor

@eofff eofff commented Oct 7, 2025

Description

Remove e2e log filter of fixed error: "Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers"

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: api
type: chore
summary: Remove e2e log filter of fixed error 'found new finalizers'.
impact_level: low

Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff self-assigned this Oct 7, 2025
Copy link
Contributor

sourcery-ai bot commented Oct 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Clean up e2e tests by removing the obsolete log filter for the resolved "new finalizers" error from default_config.yaml.

File-Level Changes

Change Details Files
Obsolete log filter removal
  • Deleted the 'Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers' entry from the logFilter list
tests/e2e/default_config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Oct 7, 2025
@eofff eofff added this to the v1.2.0 milestone Oct 7, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Oct 7, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Oct 7, 2025
@eofff eofff changed the title remove chore: remove e2e log filter of fixed error: "found new finalizers" Oct 8, 2025
@eofff eofff marked this pull request as ready for review October 8, 2025 08:28
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@eofff eofff merged commit 1298be6 into main Oct 8, 2025
63 of 91 checks passed
@eofff eofff deleted the chore/remove-found-new-finalizer-log-filter branch October 8, 2025 08:36
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
asyachmenevflant pushed a commit that referenced this pull request Oct 15, 2025
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
…1544)

Signed-off-by: Valeriy Khorunzhin <[email protected]>
(cherry picked from commit 1298be6)
Signed-off-by: Maksim Fedotov <[email protected]>
Isteb4k pushed a commit that referenced this pull request Oct 15, 2025
…1544)

Signed-off-by: Valeriy Khorunzhin <[email protected]>
(cherry picked from commit 1298be6)
Signed-off-by: Isteb4k <[email protected]>
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
…1544)

Signed-off-by: Valeriy Khorunzhin <[email protected]>
(cherry picked from commit 1298be6)
Signed-off-by: Maksim Fedotov <[email protected]>
nevermarine pushed a commit that referenced this pull request Oct 15, 2025
…1544)

Signed-off-by: Valeriy Khorunzhin <[email protected]>
(cherry picked from commit 1298be6)
Signed-off-by: Maksim Fedotov <[email protected]>
universal-itengineer pushed a commit that referenced this pull request Oct 15, 2025
…1544)

Signed-off-by: Valeriy Khorunzhin <[email protected]>
(cherry picked from commit 1298be6)
Signed-off-by: Maksim Fedotov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants