Skip to content

Conversation

@eofff
Copy link
Contributor

@eofff eofff commented Nov 24, 2025

Description

Force the failed state of a snapshot that cannot be taken right now.

Why do we need it, and what problem does it solve?

The snapshot should reflect the current state of the virtual machine and disk. Waiting for favorable conditions is unacceptable.

What is the expected result?

If a snapshot cannot be taken right now, it will no longer be in the Pending phase. Its failure will be forced.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Nov 24, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 24, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 25, 2025
@eofff eofff force-pushed the chore/snapshots/fail-if-cant-immediatly branch from f9648aa to 29df22d Compare November 26, 2025 09:15
@Isteb4k Isteb4k added this to the v1.3.0 milestone Nov 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Nov 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 26, 2025
@eofff eofff changed the title chore(api): force fail snapshots not pending chore(api): force the failed state of a snapshot that cannot be taken right now Nov 27, 2025
@eofff eofff marked this pull request as ready for review November 27, 2025 07:36
Valeriy Khorunzhin added 3 commits November 27, 2025 10:39
m
Signed-off-by: Valeriy Khorunzhin <[email protected]>
fix
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the chore/snapshots/fail-if-cant-immediatly branch from 72cde1f to 7416f51 Compare November 27, 2025 07:41
@eofff eofff requested a review from danilrwx November 27, 2025 08:04
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff merged commit ddeae3d into main Nov 28, 2025
22 of 23 checks passed
@eofff eofff deleted the chore/snapshots/fail-if-cant-immediatly branch November 28, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants