Skip to content

fix(vmbda): do not change phase to pending if vm is migrating #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eofff merged 6 commits into from
Jan 12, 2026
Merged

fix(vmbda): do not change phase to pending if vm is migrating #1852

eofff merged 6 commits into from
Jan 12, 2026

Conversation

@eofff
Copy link
Contributor

@eofff eofff commented Dec 25, 2025 •
edited
Loading

Description

Do not change phase to pending if vm is migrating.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmbda 
type: fix
summary: Do not change phase to pending if vm is migrating.

@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Dec 25, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 25, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 26, 2025
fix
87d2844 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the fix/vmbda/must-attached-while-vm-migrating branch from 6923d6c to 87d2844 Compare January 12, 2026 07:31
Valeriy Khorunzhin added 3 commits January 12, 2026 12:09
add unit test
4c58eee 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
update year)
876aea7 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
refactoring
2fefa61 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the fix/vmbda/must-attached-while-vm-migrating branch from 95300f5 to 2fefa61 Compare January 12, 2026 09:32
@eofff eofff changed the title fix fix(vmbda): do not change phase to pending if vm is migrating Jan 12, 2026
@eofff eofff added this to the v1.4.0 milestone Jan 12, 2026
@eofff eofff marked this pull request as ready for review January 12, 2026 09:35
@eofff eofff marked this pull request as draft January 12, 2026 09:38
improve text messages
a33aac4 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff marked this pull request as ready for review January 12, 2026 09:50
back year)
10c832d 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff merged commit cb32a89 into main Jan 12, 2026
27 of 28 checks passed
@eofff eofff deleted the fix/vmbda/must-attached-while-vm-migrating branch January 12, 2026 11:21
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Jan 12, 2026
Open
Isteb4k pushed a commit that referenced this pull request Jan 13, 2026
@eofff @Isteb4k
fix(vmbda): do not change phase to pending if vm is migrating (#1852)
e82707c 
Signed-off-by: Valeriy Khorunzhin <[email protected]>
(cherry picked from commit cb32a89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@eofff @deckhouse-BOaTswain @yaroslavborbat