refactor(core): cdi-controller replaces bash usage with static binaries #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universal-itengineer
force-pushed
the
chore/core/cdi-controller-remove-bash-utils
branch
15 times, most recently
from
c922580 to
4209d8d
Compare
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
universal-itengineer
force-pushed
the
chore/core/cdi-controller-remove-bash-utils
branch
from
4209d8d to
2ec2cb1
Compare
universal-itengineer
requested review from
Isteb4k,
diafour,
fl64,
nevermarine and
yaroslavborbat
as code owners
diafour
reviewed
Mar 24, 2025
diafour
previously approved these changes
Mar 24, 2025
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Nikita Korolev <[email protected]>
diafour
previously approved these changes
Mar 24, 2025
Signed-off-by: Nikita Korolev <[email protected]>
universal-itengineer
changed the title
universal-itengineer
changed the title
diafour
approved these changes
Mar 24, 2025
universal-itengineer
deleted the
chore/core/cdi-controller-remove-bash-utils
branch
Merged
Merged
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
…es (#875) cdi-controller: replaces bash usage with static binaries --------- Signed-off-by: Nikita Korolev <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the transfer to distroless images, in cdi-controller commands
"echo hello cdi"andcat /tmp/readychanged to single binary hello and printFile.Why do we need it, and what problem does it solve?
This is part of the image migration to a distroless.
What is the expected result?
Checklist
Changelog entries