Skip to content

refactor(core): cdi-cloner bash to go and cdi-controller #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
universal-itengineer merged 24 commits into from
Mar 26, 2025
Merged

refactor(core): cdi-cloner bash to go and cdi-controller #877

universal-itengineer merged 24 commits into from
Mar 26, 2025

Conversation

@universal-itengineer
Copy link
Member

@universal-itengineer universal-itengineer commented Mar 24, 2025 •
edited
Loading

Description

Rewrite cloner_startup.sh to golang
Refactor static binaries import and build for cdi controller and cloner:

  • controller needs static bin printFile
  • cloner needs static bin hello

Why do we need it, and what problem does it solve?

Getting rid of bash scripts

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: chore
summary: cloner_startup.sh to go, refactor static binaries build and import
impact_level: low

@universal-itengineer universal-itengineer added this to the v0.18.0 milestone Mar 24, 2025
@universal-itengineer universal-itengineer force-pushed the chore/core/cdi-cloner-bash-to-go branch 4 times, most recently from f07b3f8 to ffef5b6 Compare March 24, 2025 15:23
@universal-itengineer universal-itengineer changed the title chore(core): cdi-cloner cloner_startup.sh to go chore(core): cdi-cloner bash to go Mar 25, 2025
@universal-itengineer universal-itengineer force-pushed the chore/core/cdi-cloner-bash-to-go branch 9 times, most recently from cca4be7 to 0484116 Compare March 25, 2025 13:08
@universal-itengineer universal-itengineer marked this pull request as ready for review March 25, 2025 13:51
Isteb4k
Isteb4k requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@Isteb4k Isteb4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to add a linter.

diafour
diafour reviewed Mar 25, 2025
View reviewed changes
@universal-itengineer universal-itengineer force-pushed the chore/core/cdi-cloner-bash-to-go branch 6 times, most recently from b32fc04 to 8689148 Compare March 26, 2025 14:01
universal-itengineer and others added 17 commits March 26, 2025 17:09
@universal-itengineer
remove unnecessary binaries
a2e7b54 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
refactor cloner-startup
84b7dc7 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
remove install libnbd-dev
5d8b6d9 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
rm bins
3d3dee7 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
fix missing bins
2e221f7 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
refactor build static binariess, move cbuilder to cdi-artifact
8633432 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
add slog to cloner-startup
07bc58c 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer @diafour
Update images/cdi-cloner/cloner-startup/internal/helpers/size.go
caf3b52 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer @diafour
Update images/cdi-cloner/cloner-startup/internal/helpers/size.go
549f420 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer @diafour
Update images/cdi-cloner/cloner-startup/internal/helpers/size.go
83fe91e 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer @diafour
Update images/cdi-cloner/cloner-startup/internal/helpers/size.go
126c089 
Co-authored-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
refactor change dir, add golint
a841479 
Signed-off-by: Nikita Korolev <[email protected]>

fix import hello

Signed-off-by: Nikita Korolev <[email protected]>

remove commented code

Signed-off-by: Nikita Korolev <[email protected]>

rename run to cloner

Signed-off-by: Nikita Korolev <[email protected]>

update anonim func

Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
test: add var ioctlcmd for getting dev block size or device block size
15c830f 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
rm const file and fix calc total directory size
5257d3a 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
update patch 024
0660497 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
refactor GetDirectorySize and upload bytes
d319ed5 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer
refacrot GetDirectorySize and preallocation
418a5df 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer force-pushed the chore/core/cdi-cloner-bash-to-go branch from 8689148 to 418a5df Compare March 26, 2025 14:09
@universal-itengineer universal-itengineer changed the title chore(core): cdi-cloner bash to go refactor(core): cdi-cloner bash to go Mar 26, 2025
@universal-itengineer universal-itengineer changed the title refactor(core): cdi-cloner bash to go refactor(core): cdi-cloner bash to go and cdi-controller Mar 26, 2025
@universal-itengineer
resolve comments
35e276d 
Signed-off-by: Nikita Korolev <[email protected]>
Isteb4k
Isteb4k previously approved these changes Mar 26, 2025
View reviewed changes
@universal-itengineer
fix log messages
8aa956d 
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer merged commit ba38be5 into main Mar 26, 2025
16 checks passed
@universal-itengineer universal-itengineer deleted the chore/core/cdi-cloner-bash-to-go branch March 26, 2025 16:00
@Isteb4k Isteb4k modified the milestones: v0.18.0, v0.17.0 Apr 28, 2025
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@universal-itengineer @diafour
refactor(core): cdi-cloner bash to go and cdi-controller (#877)
9af73d5 
refactor(core): cdi-cloner bash to go and cdi-controller

Rewrite cloner_startup.sh to golang

Refactor static binaries import and build for cdi controller and cloner:
- controller needs static bin printFile
- cloner needs static bin hello
---------

Signed-off-by: Nikita Korolev <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diafour diafour diafour approved these changes

@Isteb4k Isteb4k Isteb4k left review comments

@nevermarine nevermarine Awaiting requested review from nevermarine nevermarine is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

Assignees

@universal-itengineer universal-itengineer

Labels

None yet

Projects

None yet

Milestone

v0.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@universal-itengineer @diafour @Isteb4k