Skip to content

fix(module): add CRD check for DVCR ServiceMonitor and ScrapeConfig #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fl64 merged 1 commit into from
Mar 25, 2025
Merged

fix(module): add CRD check for DVCR ServiceMonitor and ScrapeConfig #884

fl64 merged 1 commit into from
Mar 25, 2025

Conversation

@fl64
Copy link
Member

@fl64 fl64 commented Mar 25, 2025 •
edited
Loading

Description

add CRD check for DVCR ServiceMonitor and ScrapeConfig

Why do we need it, and what problem does it solve?

We need to be able to do a minimal installation without using prometheus.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: fix
summary: add CRD check for DVCR ServiceMonitor and ScrapeConfig
impact_level: low

@fl64 fl64 added this to the v0.17.0 milestone Mar 25, 2025
@fl64 fl64 force-pushed the fix/module/add-crd-check-for-dvcr-sm branch from eda6e5b to 88bb576 Compare March 25, 2025 18:39
@fl64 fl64 changed the title fix(module): add CRD check for DVCR service monitor resource fix(module): add CRD check for DVCR ServiceMonitor and ScrapeConfig Mar 25, 2025
@fl64 fl64 marked this pull request as ready for review March 25, 2025 18:53
@fl64 fl64 requested a review from Isteb4k as a code owner March 25, 2025 18:53
@fl64 fl64 merged commit 161ce78 into main Mar 25, 2025
20 checks passed
@fl64 fl64 deleted the fix/module/add-crd-check-for-dvcr-sm branch March 25, 2025 18:55
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@fl64
fix(module): add CRD check for DVCR ServiceMonitor and ScrapeConfig (#…
679c8de 
…884)

Signed-off-by: Pavel Tishkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

Assignees

@fl64 fl64

Labels

None yet

Projects

None yet

Milestone

v0.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fl64 @yaroslavborbat