-
Notifications
You must be signed in to change notification settings - Fork 3
refactor(core): add binaries, remove unnecessary, change build images #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
universal-itengineer
merged 81 commits into
main
from
chore/core/cleanup-unnecessary-binaries
Apr 11, 2025
Merged
refactor(core): add binaries, remove unnecessary, change build images #895
universal-itengineer
merged 81 commits into
main
from
chore/core/cleanup-unnecessary-binaries
Apr 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84365b2 to
9ad0388
Compare
232e2ef to
e177493
Compare
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
…t_runtime_us' Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Nikita Korolev <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Nikita Korolev <[email protected]>
Co-authored-by: Ivan Mikheykin <[email protected]> Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
a87319b to
3026d20
Compare
Signed-off-by: Nikita Korolev <[email protected]>
images/virt-artifact/patches/044-hotplug-attachment-trigger-pod-remove-bash.patch
Show resolved
Hide resolved
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
diafour
approved these changes
Apr 11, 2025
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
…#895) This PR refactors container images to improve security and efficiency. Changes impact the following components: bounder cdi-artifact cdi-cloner cdi-importer dvcr-artifact virt-artifact virt-handler virt-launcher virt-operator Key changes: Shell removal: Replaced bash/sh dependencies with statically compiled binaries (e.g., temp_pod), eliminating shell-based commands like echo. KubeVirt patches: 041-rename-node-labeller-virt-launcher-init.patch: Replace "/bin/sh","-c","node-labeller" to "node-labeller" 045-virt-launcher-image-holder-command-sleep.patch: Simplified virt-launcher-image-holder command from sh -c "sleep infinity" to sleep infinity. 046-hotplug-attachment-trigger-pod-remove-bash.patch: Replaced shell invocations in init containers with direct binary execution. 047-node-labeller-replace-sysctl-command-with-readfile.patch: replacing linux util sysctl to os.ReadFile("/proc/sys/kernel/sched_rt_runtime_us") in virt-handler Test fixes: Updated vmi_test.go assertions to align with new command syntax (e.g., Equal("temp_pod")). virt-launcher enhancements: Fixed library inclusion steps in the image build process --------- Signed-off-by: Nikita Korolev <[email protected]> Co-authored-by: Ivan Mikheykin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors container images to improve security and efficiency. Changes impact the following components:
boundercdi-artifactcdi-clonercdi-importerdvcr-artifactvirt-artifactvirt-handlervirt-launchervirt-operatorKey changes:
bash/shdependencies with statically compiled binaries (e.g.,temp_pod), eliminating shell-based commands likeecho.041-rename-node-labeller-virt-launcher-init.patch: Replace"/bin/sh","-c","node-labeller"to"node-labeller"045-virt-launcher-image-holder-command-sleep.patch: Simplifiedvirt-launcher-image-holdercommand fromsh -c "sleep infinity"tosleep infinity.046-hotplug-attachment-trigger-pod-remove-bash.patch: Replaced shell invocations in init containers with direct binary execution.047-node-labeller-replace-sysctl-command-with-readfile.patch: replacing linux utilsysctltoos.ReadFile("/proc/sys/kernel/sched_rt_runtime_us")in virt-handlervmi_test.goassertions to align with new command syntax (e.g.,Equal("temp_pod")).Why do we need it, and what problem does it solve?
Problem Solved
bash/shintroduced potential security vulnerabilities and increased image size.sh -c "...") complicated maintenance and auditingWhat is the expected result?
Checklist
Changelog entries