test(vm): reboot using nohup #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
test/vm/force-reboot
branch
from
d2a347e to
ff9c6cd
Compare
Isteb4k
requested review from
fl64,
hardcoretime and
yaroslavborbat
and removed request for
hardcoretime
danilrwx
approved these changes
Apr 1, 2025
fl64
approved these changes
Apr 1, 2025
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
We had tests failing because the command ssh `reboot -f` was not executing completely. More precisely, the reboot request was sent, and the virtual machine rebooted successfully, but the SSH session remained active throughout the reboot process and eventually disconnected with a timeout error: > Error: websocket: close 1006 (abnormal closure): unexpected EOF This caused the test to fail. The `-f` flag was causing this behavior. Without it, everything worked fine. I resolved it by rebooting with `nohup reboot -f`. Signed-off-by: Isteb4k <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had tests failing because the command ssh
reboot -fwas not executing completely. More precisely, the reboot request was sent, and the virtual machine rebooted successfully, but the SSH session remained active throughout the reboot process and eventually disconnected with a timeout error:This caused the test to fail. The
-fflag was causing this behavior. Without it, everything worked fine. I resolved it by rebooting withnohup reboot -f.Checklist
Changelog entries