fix dynamic imports for Deno Deploy #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoferreiradev
force-pushed
the
fix/dynamic-resolve
branch
from
dbe185a to
c68a98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We identified inconsistent behavior in Deno Deploy related to dynamic imports using import.meta.resolve() with HTMX. The issue would mainly occur when making changes to files that performed dynamic imports or to the imported files themselves.
To ensure better stability, we added static imports in main.ts. This simple solution ensures that Deno Deploy's bundler correctly includes all necessary files while maintaining the existing dynamic loading functionality via HTMX without any logic changes.
Discord threads