Skip to content

Conversation

@hpgrahsl
Copy link
Contributor

@hpgrahsl hpgrahsl commented Jun 11, 2025

  • deprecate existing serde related methods in interfaces
  • add new serde methods tied type-wise to our default impl
  • provide default JSON serde implementations
  • add tests and utility classes for working with keyed decodable streams
  • rewrite existing / add new examples showing how to handle keyless vs keyed records

this PR address #6

- deprecate existing serde methods from interfaces
- add new serde methods tied type-wise to our default impl
- provide default JSON serde implementations
- add tests and utility classes for working with keyed decodable streams
- rewrite existing / add new examples showing how to handle keyless vs keyed records
@hpgrahsl hpgrahsl requested review from jmahonin and sharonx June 11, 2025 12:40
hpgrahsl added 4 commits June 12, 2025 21:10
this is necessary since decodable flink runtime ships with relocated kafka-clients classes
which otherwise couldn't be resolved on the classpath

the other option would be to relocate these classes in the SDK's build already
but this would still require some modification to this build otherwise tests would
locally fail
Copy link
Contributor

@sharonx sharonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hpgrahsl hpgrahsl marked this pull request as ready for review June 26, 2025 20:17
@hpgrahsl
Copy link
Contributor Author

As discussed with product (@sharonx) we are merging this. Changing existing / adding further example jobs will be done at a later stage if necessary.

@hpgrahsl hpgrahsl merged commit 980cbd3 into main Jul 25, 2025
4 checks passed
@github-actions github-actions bot added the released Issue has been released label Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

🎉 This issue has been resolved in v1.0.0.Alpha5 (Release Notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Issue has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants