-
Notifications
You must be signed in to change notification settings - Fork 4
add support for full record (key+value) access #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deprecate existing serde methods from interfaces - add new serde methods tied type-wise to our default impl - provide default JSON serde implementations - add tests and utility classes for working with keyed decodable streams - rewrite existing / add new examples showing how to handle keyless vs keyed records
this is necessary since decodable flink runtime ships with relocated kafka-clients classes which otherwise couldn't be resolved on the classpath the other option would be to relocate these classes in the SDK's build already but this would still require some modification to this build otherwise tests would locally fail
sharonx
reviewed
Jun 12, 2025
...k-1.16/src/main/java/co/decodable/sdk/pipeline/serde/DecodableRecordSerializationSchema.java
Show resolved
Hide resolved
- allow for value only constructor in DecodableAbstractStreamRecord - improve error message and exception handling in Serde code - adapt usage in job test
sharonx
approved these changes
Jun 16, 2025
Contributor
sharonx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…and different from Void
…eams - keyed2keyless append stream - keyless2keyed append stream
Contributor
Author
|
As discussed with product (@sharonx) we are merging this. Changing existing / adding further example jobs will be done at a later stage if necessary. |
|
🎉 This issue has been resolved in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR address #6