Create new mix clients in Wallet.Run.#2590
Merged
jrick merged 1 commit intodecred:masterfrom Dec 1, 2025
Merged
Conversation
The wallet's Run method, which is invoked by the syncers to run the background goroutines necessary to run the mixing client, will be run multiple times by the RPC syncer (as syncers must be created following loss of the RPC connection). However, mixclient does not work properly after the first context cancelation. This would cause all mixing activity to silently not work, technically hanging in mixclient, while never hanging any other wallet activity. This can be worked around in wallet without mixclient changes by recreating a new client each time in wallet's Run method. Additional synchronization is required to avoid racing on the mixclient pointer.
davecgh
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wallet's Run method, which is invoked by the syncers to run the background goroutines necessary to run the mixing client, will be run multiple times by the RPC syncer (as syncers must be created following loss of the RPC connection). However, mixclient does not work properly after the first context cancelation. This would cause all mixing activity to silently not work, technically hanging in mixclient, while never hanging any other wallet activity.
This can be worked around in wallet without mixclient changes by recreating a new client each time in wallet's Run method. Additional synchronization is required to avoid racing on the mixclient pointer.