Update wire to fix a potential use-after-free#2614
Open
jrick wants to merge 1 commit intodecred:masterfrom
Open
Update wire to fix a potential use-after-free#2614jrick wants to merge 1 commit intodecred:masterfrom
jrick wants to merge 1 commit intodecred:masterfrom
Conversation
MsgTx decoding could result in caller-provided scripts being incorrectly added to the script freelist when decoding errors. These scripts will be reused during later deserializations, overwriting the existing scripts caller previously provided. This is, in other words, the same as a use-after-free violation in languages with manual memory management. wire v1.7.3 provides a mitigation for this issue, as well as other performance improvements and addrv2 message support that dcrwallet will eventually benefit from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MsgTx decoding could result in caller-provided scripts being incorrectly added to the script freelist when decoding errors. These scripts will be reused during later deserializations, overwriting the existing scripts caller previously provided. This is, in other words, the same as a use-after-free violation in languages with manual memory management.
wire v1.7.3 provides a mitigation for this issue, as well as other performance improvements and addrv2 message support that dcrwallet will eventually benefit from.