Prevent improper rendering of SVG graphics #1405
Merged
+249
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix svg transcoding exceptions when width or height is undefined (<=0) + add test for svg transcoding
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of the larger PR #1207
It contains corrections that avoid misrepresentation when height or width are undefined.
The modification in the ShapeHelper does not change the current references of the the class.
It only converts the soft reference to a compile-time reference, so that if Xerces may be removed in future the dependence becomes recognizable.
It also provides a fix when SVG graphics are not properly transformed to Shape (the viewbox/width/height handling was problematic or has become problematic over time)
A parameter
deegree.rendering.svg-to-shape.previouswas introduced, so that the previous behavior can be re-enabled (for those case when styles have been wrongly set sizes to compensate for the issue)