Skip to content

Conversation

@lgoltz
Copy link
Contributor

@lgoltz lgoltz commented Dec 15, 2025

Before this PR the configured legend is requested each time the capabilities are requested to determine the size of the legend:

<l:StyleRef>		
  <l:StyleStoreId>styles</l:StyleStoreId>		
    <l:Style>
      <l:StyleName>test</l:StyleName>
      <l:LayerNameRef>test_layer</l:LayerNameRef>
      <l:StyleNameRef>test</l:StyleNameRef>
      <l:LegendGraphic outputGetLegendGraphicUrl="false">https://deegree.org/legends/legend.png</l:LegendGraphic>
    </l:Style>
</l:StyleRef>

This PRs fixes this by storing the legend size in the styles instance.

@lgoltz lgoltz added the WMS deegree Web Map Service label Dec 15, 2025
@lgoltz lgoltz added this to the 3.6.6 milestone Dec 15, 2025
@tfr42 tfr42 changed the title Fix requests of legends each time the capabilities are requested Fixed requesting of legend graphics each time the capabilities are requested Dec 22, 2025
@dstenger
Copy link
Contributor

dstenger commented Jan 7, 2026

A functional test was successful.
main-Branch: When using the snippet documented in the description, the legend is requested when requesting the capabilities. This applies to all additional requests.
Branch of this PR: When using the snippet documented in the description, the legend is only requested when requesting the capabilities for the first time. Afterwards, the legend is not requested anymore.

@stephanr
Copy link
Member

As a small remark, this may interfere in a setup where the legend graphic on disk or remote changes (in size) over time.

@copierrj copierrj merged commit 92e469c into deegree:main Jan 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WMS deegree Web Map Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants